Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pass at new pictureframe model #394

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drlaw1558
Copy link
Contributor

This is an initial attempt at a new datamodel for the NIRSpec thermal picture frame reference file, see https://jira.stsci.edu/browse/CRDS-925

@drlaw1558 drlaw1558 requested a review from a team as a code owner February 5, 2025 19:05
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (4e83608) to head (6c36ad0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   78.16%   78.47%   +0.31%     
==========================================
  Files         115      116       +1     
  Lines        5144     5167      +23     
==========================================
+ Hits         4021     4055      +34     
+ Misses       1123     1112      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drlaw1558 drlaw1558 marked this pull request as draft February 5, 2025 21:37
@drlaw1558
Copy link
Contributor Author

Put this back to draft since there may still be some iteration on the file format over the next week or so.

@drlaw1558 drlaw1558 marked this pull request as ready for review February 19, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant