Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused functions #420

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 24, 2025

Resolves JP-nnnn
Resolves RCAL-nnnn

Closes #404
Closes #412
Closes #414
Closes #415
Closes #416
Closes #417 blocked by spacetelescope/jwst#9219

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/13506784800

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (4e83608) to head (dd02aab).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/stdatamodels/fits_support.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   78.16%   78.41%   +0.24%     
==========================================
  Files         115      112       -3     
  Lines        5144     5101      -43     
==========================================
- Hits         4021     4000      -21     
+ Misses       1123     1101      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant