Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use GITHUB_TOKEN in docker build #130

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: use GITHUB_TOKEN in docker build #130

merged 1 commit into from
Oct 31, 2023

Conversation

jonoliver
Copy link
Member

@jonoliver jonoliver commented Oct 31, 2023 •
edited
Loading

Description

Updates the docker workflow to use the auto-generated GITHUB_TOKEN instead of one that we set.

To Validate

  1. Make sure all PR Checks have passed
  2. View the successful deployment workflow run, dispatched from this branch
  3. View the latest Docker image that was pushed by the above workflow

@jonoliver jonoliver mentioned this pull request Oct 31, 2023
Merged
dustin-jw
dustin-jw approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@dustin-jw dustin-jw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jonoliver jonoliver force-pushed the chore--update-docker-token branch from 927f64b to 94af045 Compare October 31, 2023 20:04
@jonoliver jonoliver merged commit 94af045 into main Oct 31, 2023
2 checks passed
@jonoliver jonoliver deleted the chore--update-docker-token branch October 31, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-jw dustin-jw dustin-jw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonoliver @dustin-jw