Pull in branch "Feature/16 bit data support" changes into develop - next step is a release #39
Conversation
…the I2C bus to determine if uint16_t transfers need to swap bytes; note- Arduino SPI does this correctly
…pr approach does not work on all compliers -- needs > c++11
…ade Arduino like consts for order types
…d. move to leverage the fast built in versions
… older compilers/tool chain setups
… core toolkit, provide impl in platform specific driver - better than the namespace thing
gigapod
requested review from
lewispg228,
SFE-Brudnerd,
sfe-SparkFro and
malcolm-sparkfun
… to 4 chars, all lowercase
|
For the C function names sfeTk_<> to sfTk_<> I was going to do sfetk_<*> but the prefix of 5 chars seemed tedious to me - normally like to keep that to 2-4 chars. But you are correct, this differs from the class names and path used for the toolkit - sfeTk .... we could go to sfTk. Let's discuss tomorrow - I have no issue with it. |
src/sfeTkArdI2C.cpp
Outdated
| @@ -209,11 +209,34 @@ sfeTkError_t sfeTkArdI2C::writeRegisterRegion(uint8_t devReg, const uint8_t *dat | |||
| // | |||
| sfeTkError_t sfeTkArdI2C::writeRegister16Region(uint16_t devReg, const uint8_t *data, size_t length) | |||
| { | |||
| devReg = ((devReg << 8) & 0xff00) | ((devReg >> 8) & 0x00ff); | |||
| // devReg = ((devReg << 8) & 0xff00) | ((devReg >> 8) & 0x00ff); | |||
There was a problem hiding this comment.
Can remove comment now that this has been replaced
src/sfeTkArdI2C.cpp
Outdated
|
|
||
| // okay, we need to swap | ||
| devReg = sftk_byte_swap(devReg); | ||
| // devReg = ((devReg << 8) & 0xff00) | ((devReg >> 8) & 0x00ff); |
There was a problem hiding this comment.
Can remove comment now that this has been replaced.
| // devReg = ((devReg << 8) & 0xff00) | ((devReg >> 8) & 0x00ff); | ||
| uint16_t data16[length]; | ||
| for (size_t i = 0; i < length; i++) | ||
| data16[i] = ((data[i] << 8) & 0xff00) | ((data[i] >> 8) & 0x00ff); |
There was a problem hiding this comment.
Can we use the uint16_t sftk_byte_swap() overload here instead of doing it explicitly?
src/sfeTkArdI2C.cpp
Outdated
| { | ||
| // if the system byte order is the same as the desired order, flip the address | ||
| if (sftk_system_byteorder() != _byteOrder) | ||
| devReg = ((devReg << 8) & 0xff00) | ((devReg >> 8) & 0x00ff); |
There was a problem hiding this comment.
Can we use the uint16_t sftk_byte_swap() overload here instead of doing it explicitly?
src/sfeTkArdI2C.cpp
Outdated
| if (status == kSTkErrOk && sftk_system_byteorder() != _byteOrder) | ||
| { | ||
| for (size_t i = 0; i < numBytes; i++) | ||
| data[i] = ((data[i] << 8) & 0xff00) | ((data[i] >> 8) & 0x00ff); |
There was a problem hiding this comment.
Can we use the uint16_t sftk_byte_swap() overload here instead of doing it explicitly?
|
FYI - Merging into dev. |
… hard coded bit fiddling
Move the latest updates into the develop branch. Once merged ,will spin out a release.
Main changes: