fix: sfn update to use template file for applying stack #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
When updating stack introduces a new parameter, although it's in output of
--apply-stack
, currentsfn update
prompts user input for the parameter. It's becausepopulate_parameters
function checks for the current stack's template, not the given template file.(I've added additional loggings for debugging purposes)
Without this fix, it's prompting user input for
SsmStopRoleArn2
becausereceiver_stack (sfn-stack-2) valid_parameters
didn't check the newly given template's parameters.With this fix,
receiver_stack (sfn-stack-2) valid_parameters
detects the newly introduced parameter, and it applies the value from the outputs.