Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change markdown standard to GFM #812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tachyonicClock
Copy link

Change markdown standard to Github Flavored Markdown (GFM) replacing Pandoc's default markdown. This is consistent with the Jupyter Notebook markdown cells and should improve compatibility (https://nbformat.readthedocs.io/en/latest/format_description.html#markdown-cells).

@pep8speaks
Copy link

pep8speaks commented Sep 4, 2024

Hello @tachyonicClock! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1044:80: E501 line too long (104 > 79 characters)

Comment last updated at 2024-09-04 22:52:54 UTC

Change markdown standard to Github Flavored Markdown (GFM) replacing Pandoc's
default markdown. This is consistent with the Jupyter Notebook markdown cells
and should improve compatibility.
@mgeier
Copy link
Member

mgeier commented Sep 14, 2024

Thanks for this PR!

I wasn't aware that Jupyter uses GFM. First I thought this was changed recently, but apparently this has been supported for a long time!

So I'm all for also using it in nbsphinx, but this PR seems to break a few things:

  • LaTeX environments and macros like \ref{}
  • HTML elements
  • "warning" box within "note" box

This might not be a full list, for now I only looked at markdown-cells.ipynb.

@douglas-raillard-arm
Copy link
Contributor

Drive-by comment: have you considered also making a similar PR in jupyter nbconvert ? Both projects unfortunately do not share the pandoc invocation, but I think most users would expect them to behave the same way (at least I did).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants