Serializeable closure support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Apr 24, 2024
| $frames[] = new Frame( | ||
| $snippet = null; | ||
|
|
||
| if (substr($currentFile, 0, strlen(ClosureStream::STREAM_PROTO)) === ClosureStream::STREAM_PROTO) { |
src/Frame.php
Outdated
| @@ -41,22 +51,24 @@ public function __construct( | |||
| $this->class = $class; | |||
|
|
|||
| $this->applicationFrame = $isApplicationFrame; | |||
|
|
|||
| $this->snippet = $snippet; | |||
There was a problem hiding this comment.
Maybe rename this to textSnippet? To make it really clear that this isn't a CodeSnippet object.
| @@ -157,7 +159,7 @@ public function it_can_get_the_snippet_properties() | |||
| $snippet = $firstFrame->getSnippetProperties(5); | |||
|
|
|||
| $this->assertStringContainsString('$firstFrame =', $snippet[2]['text']); | |||
| $this->assertEquals(154, $snippet[2]['line_number']); | |||
| $this->assertEquals(__LINE__ - 5, $snippet[2]['line_number']); | |||
|
Doesn't the "laravel/serializable-closure" dependency needs to be in the "require" section? It is in the "require-dev" section now. |
|
Good point, taught it was only used in testing but the constant is a problem here. I'll fix it! |
|
@vovayatsyuk good point @rubenvanassche It might be better to add a |
|
@freekmurze Yeah good idea! |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializeable closures can break backtraces, lets fix this!