Enhance Sortable Interface with Mass Update and Deletion Ordering Methods #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.) added: refactored views Signed-off-by: Oskars Germovs <[email protected]>
2.) added: bugfix to bootSortableTrait is not set if not used in model as fallback Signed-off-by: Oskars Germovs <[email protected]>
Signed-off-by: Oskars Germovs <[email protected]>
Signed-off-by: Oskars Germovs <[email protected]>
2.) added: bugfix and proper test coverage for deleting 3.) added: changes to config to avoid issues with old version package users Signed-off-by: Oskars Germovs <[email protected]>
|
In order to keep this package simple and adhere to our coding standards, we're going to pass on this one for now. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
Sortableinterface in thespatie/eloquent-sortablepackage. Key changes include:declare(strict_types=1);to enforce strict typing and improve type safety.setMassNewOrder()method to support efficient reordering of multiple records at once, reducing overhead in batch operations.shouldSortWhenUpdating()andshouldSortWhenDeleting()methods to provide better control over model sorting behavior during updates and deletions.These changes improve flexibility and performance for users who need fine-grained control over the ordering behavior of their Eloquent models, particularly in large data sets or when reordering frequently.