Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October Improvements 2/2 #119

Merged
merged 4 commits into from
Nov 2, 2023
Merged

October Improvements 2/2 #119

merged 4 commits into from
Nov 2, 2023

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Oct 24, 2023

@phschaad phschaad changed the title Adapt to change in naming October Improvements 2/2 Oct 24, 2023
@phschaad phschaad marked this pull request as ready for review November 1, 2023 15:42
@phschaad phschaad requested a review from tbennun November 1, 2023 15:42
Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve in general but have a minor unicomment

let label = '';
if (this.attributes().assignments) {
for (const k of Object.keys(this.attributes().assignments))
label += k + ' 🡐 ' + this.attributes().assignments[k] + '\n';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it may not be supported everywhere (encoding dependent). Is there a way of adding a \u code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed it by adding proper multi-line support (i.e., printing individual labels for each line). Thank you for pointing this out - the method I chose is only supported by very few browsers and does not follow the fillText canvas API specifications.

@phschaad phschaad merged commit 8961a69 into master Nov 2, 2023
2 checks passed
@phschaad phschaad deleted the adapt_loop_region branch November 2, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants