Skip to content

Commit

Permalink
Addressed review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
alexnick83 committed Nov 16, 2023
1 parent 456c913 commit b5160f4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion dace/codegen/targets/cpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def allocate_array(self, sdfg, dfg, state_id, node, nodedesc, function_stream, d
tokens = node.data.split('.')
top_desc = sdfg.arrays[tokens[0]]
# NOTE: Assuming here that all Structure members share transient/storage/lifetime properties.
# TODO: Study what is needed in the DaCe stuck to ensure this assumption is correct.
# TODO: Study what is needed in the DaCe stack to ensure this assumption is correct.
top_transient = top_desc.transient
top_storage = top_desc.storage
top_lifetime = top_desc.lifetime
Expand Down
2 changes: 1 addition & 1 deletion dace/codegen/targets/framecode.py
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ def determine_allocation_lifetime(self, top_sdfg: SDFG):

for sdfg, name, desc in top_sdfg.arrays_recursive(include_nested_data=True):
# NOTE: Assuming here that all Structure members share transient/storage/lifetime properties.
# TODO: Study what is needed in the DaCe stuck to ensure this assumption is correct.
# TODO: Study what is needed in the DaCe stack to ensure this assumption is correct.
top_desc = sdfg.arrays[name.split('.')[0]]
top_transient = top_desc.transient
top_storage = top_desc.storage
Expand Down
4 changes: 2 additions & 2 deletions dace/sdfg/sdfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -1224,8 +1224,8 @@ def remove_node(self, node: SDFGState):
return super().remove_node(node)

def states(self):
""" Alias that returns the nodes (states) in this SDFG. """
return self.nodes()
""" Returns the states in this SDFG, recursing into state scope blocks. """
return list(self.all_states())

def all_nodes_recursive(self) -> Iterator[Tuple[nd.Node, Union['SDFG', 'SDFGState']]]:
""" Iterate over all nodes in this SDFG, including states, nodes in
Expand Down
3 changes: 1 addition & 2 deletions dace/transformation/interstate/sdfg_nesting.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@
import operator
import copy

from dace import memlet, registry, sdfg as sd, Memlet, symbolic, dtypes, subsets
from dace import memlet, Memlet, symbolic, dtypes, subsets
from dace.frontend.python import astutils
from dace.sdfg import nodes, propagation, utils
from dace.sdfg.graph import MultiConnectorEdge, SubgraphView
from dace.sdfg.replace import replace_properties_dict
from dace.sdfg import SDFG, SDFGState
from dace.sdfg import utils as sdutil, infer_types, propagation
from dace.transformation import transformation, helpers
Expand Down

0 comments on commit b5160f4

Please sign in to comment.