Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Duplicate memlet error with add_memlet_path #1362

Closed
wants to merge 1 commit into from
Closed

Bugfix: Duplicate memlet error with add_memlet_path #1362

wants to merge 1 commit into from

Conversation

lukastruemper
Copy link
Contributor

No description provided.

@lukastruemper
Copy link
Contributor Author

This happens in some code generator in a project. Wouldn't know how to write a test case tbh

@tbennun
Copy link
Collaborator

tbennun commented Sep 6, 2023

I think it's the API user's responsibility that a unique memlet is passed into add_memlet_path. Who is calling it with the same object more than once?

@tbennun
Copy link
Collaborator

tbennun commented Sep 6, 2023

To be clear, this would create slowdowns as for almost all the add_memlet_path calls, a new memlet is created for them.

@lukastruemper lukastruemper deleted the duplicate-memlet-bugfix branch November 24, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun Awaiting requested review from tbennun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukastruemper @tbennun