-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to work depth analysis #1363
Conversation
…ons can be passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good overall, small comments and questions only.
This reverts commit eb5a6f4.
Accidentally pushed different work to this branch, sorry! Reverted it again. |
I implemented your proposed changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the comments!
This PR adds various improvements to the work depth analysis for SDFGs. These improvements include:
Max(x + a, x + b)
, we now formulate it asx + Max(a, b)
. Ifx
also contains a max expression, the performance gains are even bigger, since this generally allows for more Max expressions to be evaluated symbolically.N>5
and hence the analysis evaluatesMax(N, 5)
toN
. Sympy does not support such assumptions out of the box, hence this PR includesassumptions.py
, which handles all kinds of equal / greater / lesser assumptions. The user can enter the assumptions directly into the VS code extension as implemented by this other PR.