Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical Control Flow / Control Flow Regions #1404
Hierarchical Control Flow / Control Flow Regions #1404
Changes from 16 commits
73616ee
a4139f6
e0c8553
3d20f80
909f032
9099017
4cc0b86
921f1ee
2f3568b
a935fe5
d84d0e3
12a09c0
be67317
c165c85
8792390
471d1dd
b3d3784
1fd2f57
c9ddcd8
a971b5a
8a32851
6d4c95f
cc66744
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the block is not an SDFGState, don't we also need to call
replace
on the block itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @phschaad is there a need to replace inside a block? Does it have its own properties? Right now it's only
is_collapsed
andlabel
, but I imagine loops would have other symbols in them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general yes, it would need such a replacement as well. However, this is only
replace_datadesc_names
. There are currently no plans of having blocks (other than states) access data descriptors directly. They should all operate on symbols.