Fixed a bug in the map fusion transformation. #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially the bug happens because the transformation considers any array with one elements as scalar, including arrays such as `(1, 1)`. This commit allows the scalar branch of the transformation to handle this kind of situation. Another solution would be to "promote" it to an array. In addition this commit adds some test cases for these kind of events.
|
The test seems to pass on I looked a bit deeper into the transformation. I also think that it's better for the scalar branch to handle this case, because inside the map it's better to use a scalar transient instead of a transient array where all dimensions have size 1. |
|
We briefly discussed this:
We are now looking into the |
|
As far as I can tell there is still a bug in the array branch. |
|
Has been superseded by PR#1629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the bug happens because the transformation considers any array with one elements as scalar, including arrays such as
(1, 1). This commit allows the scalar branch of the transformation to handle this kind of situation. Another solution would be to "promote" it to an array.In addition this commit adds some test cases for these kind of events.