Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug informations to LoopRegion #1577

Closed
wants to merge 57 commits into from
Closed

Add debug informations to LoopRegion #1577

wants to merge 57 commits into from

Conversation

luca-patrignani
Copy link
Contributor

@luca-patrignani luca-patrignani commented May 27, 2024 •
edited
Loading

NOTE: this is loop_architecture_pt_3 in disguise.
This PR is for the Week 1 milestone for my GSoC project. It adds

  • what source line range the source filename belongs to the loop body (for both for and while constructs)
  • what source line range defines the condition check (for the while construct)

These informations are stored as DebugInfoProperty in the LoopRegion class.

Needs confirmation

  • I created a separate file ( tests/loop_region_code_location_file.py) containing some functions annotated as dace program which are tested by the unit tests. I placed them to avoid messing up the line numbers every time the test file is modified.

@phschaad
Add loop regions to the frontend's capabilities
b6e9000
@phschaad
Merge branch 'master' into loop_architecture_pt_3
ced035b
@phschaad
Merge branch 'master' into loop_architecture_pt_3
0bb6223
@phschaad
Bugfixes
d26c507
@phschaad
Fix data dependent while loop generation
b83d05d
@phschaad
Merge remote-tracking branch 'origin/master' into loop_architecture_pt_3
55acc41
@phschaad
Make state propagation test more robust to SDFG changes
35e4272
@phschaad
Fixes
6b4d1be
@phschaad
newast fixes
83cf2d0
@phschaad
Change property type and add better type hinting
1393b19
@phschaad
Merge branch 'master' into loop_architecture_pt_3
864c607
@phschaad
Allow orelse and break continue
b317a12
@phschaad
Fix free symbols for loops
240ff79
@phschaad
Merge branch 'master' into loop_architecture_pt_3
016b21c
@phschaad
Merge remote-tracking branch 'origin/master' into loop_architecture_pt_3
28177c7
@phschaad
Provide pass compatibility check for passes and transformations
69eaf92
@phschaad
Update passes and transformations
975d79e
@phschaad
Make sure auto opt "works"
80e96bb
@phschaad
Refactor SDFG List to CFG List
9b7f840
@phschaad
Make sure no old style sdfg_list calls remain
bc8679f
@phschaad
Fix deserializataion for control flow regions
68a6b62
@phschaad
Fix deserialization
40cd861
@phschaad
Remove legacy calls to sdfg_list
482c30f
@phschaad
Merge branch 'refactor_sdfg_list_to_cfg_list' into loop_architecture_…
ae2e068 
…pt_3
@phschaad
Fix transformation architecture
e596496
@phschaad
Address review comments, update docs
27a350e
@phschaad
Fix blunder
5aeec96
@phschaad
Merge remote-tracking branch 'origin/refactor_sdfg_list_to_cfg_list' …
7e2aa45 
…into loop_architecture_pt_3
@phschaad
Fix incorrect arg passing
81b6972
@phschaad
Fix control flow inlining
4ca1fea
phschaad and others added 27 commits January 29, 2024 18:38
@phschaad
Fix control flow region traversal
303c605
@phschaad
Bugfixes
c1ec438
@phschaad
Fix test
a966044
@phschaad
Fix missing reset of cfg list for inlining
01b3593
@phschaad
Fix test
8af34d5
@phschaad
Added loops to fortran frontend
03e976c
@phschaad
Ensure compatibility checks
2d3d77e
@phschaad
Cleanup
a89c64d
@phschaad
Cleanup
9c06e06
@phschaad
Cleanup
a608779
@phschaad
Fix codegen bug (for loops)
926ad49
@phschaad
Fix SDFG references for complex loop condition tests
03f0d75
@phschaad
Make dreport file sorting based on version instead of state id
aad6c28
@phschaad
Fix dinstr test
a04bf0b
@phschaad
Fix duplicate control flow block naming for while condition checks
22b7456
@phschaad
Workflow debugging
abcd09e
@phschaad
pytest debugging
3e779fd
@phschaad
Fixes
1c7a569
@phschaad
Revert two changes
24a3d8a
@phschaad
Merge branch 'master' into loop_architecture_pt_3
ed3f36d
@phschaad
Merge addendum
bb6159e
@phschaad
More robustness to blocksafe wrapper
7455eb2
@phschaad
Multistate inline fix
63df04b
@phschaad
Cleanup
5869236
@luca-patrignani
Make use_experimental_cfg_blocks flag work
22108a2
@luca-patrignani
Add body_debuginfo property in LoopRegion
a9067c9
@luca-patrignani
Add debug informations for loop condition
17898b4
@luca-patrignani luca-patrignani changed the title [WIP] Add debug information to LoopRegion [WIP] Add debug informations to LoopRegion May 28, 2024
@luca-patrignani luca-patrignani changed the title [WIP] Add debug informations to LoopRegion Add debug informations to LoopRegion May 28, 2024
@luca-patrignani luca-patrignani closed this by deleting the head repository Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca-patrignani @phschaad