-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use file object directly in temporary_config()
#1598
Merged
tbennun
merged 6 commits into
spcl:master
from
philip-paul-mueller:better_temp_config_function
Jun 21, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f6da809
Fixed an error in the `temporary_config()` context manager.
philip-paul-mueller 2d10a6e
The default mode of `NamedTemporaryFile()` is `w+b`, however, since t…
philip-paul-mueller fefbd99
Fixed a bug.
philip-paul-mueller 5cfc2d4
How can you make so much errors in so little code? To be me!
philip-paul-mueller 52acbe9
Added a test for the `temorary_config()` context manager.
philip-paul-mueller 561276c
Merge remote-tracking branch 'spcl/master' into better_temp_config_fu…
philip-paul-mueller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does 't' mean in
mode
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means text mode, on UNIX
\n
is the newline character, but on Windows it is\r\n
(https://en.wikipedia.org/wiki/Newline#Representation). In that mode\r\n
is transformed into\n
it is essentially a compatibility layer, seehelp(open)
.I used it because it preserves old behaviour, but it is probably not needed.