-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python frontend stability and inline storage specification #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b28f82b.
phschaad
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbennun
changed the title
Python frontend stability and dynamic thread-block fixes
Python frontend stability and inline storage specification
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new syntax to support inline storage specification with the
@
operator, supporting the following statements:a = np.ones(M) @ dace.StorageType.CPU_ThreadLocal
.This PR also fixes multiple minor issues in the Python frontend:
WarpTiling
did not respect sequential map schedulesnumpy.fill
variants (e.g.,numpy.zeros(N)
)Dynamic map range related issues with simple modifications to the SpMV programFix deferred to No-View Nested SDFGs #1696Dynamic thread block scheduling would not pass object to nested functionsFix deferred to future PR, see Support nested SDFGs inScheduleType.GPU_ThreadBlock_Dynamic
#1189