Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python frontend stability and inline storage specification #1711

Merged
merged 19 commits into from
Oct 29, 2024
Merged

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Oct 28, 2024

The PR adds a new syntax to support inline storage specification with the @ operator, supporting the following statements: a = np.ones(M) @ dace.StorageType.CPU_ThreadLocal.

This PR also fixes multiple minor issues in the Python frontend:

  • WarpTiling did not respect sequential map schedules
  • Non-sequence inputs for numpy.fill variants (e.g., numpy.zeros(N))
  • NumPy replacement syntax errors would sometimes not have source information
  • Fix type inference for nested scopes in Python frontend
  • Dynamic map range related issues with simple modifications to the SpMV program Fix deferred to No-View Nested SDFGs #1696
  • Dynamic thread block scheduling would not pass object to nested functions Fix deferred to future PR, see Support nested SDFGs in ScheduleType.GPU_ThreadBlock_Dynamic #1189
  • Dynamic thread block scheduling does not support multi-dimensional maps
  • Default schedule inference should use dynamic thread blocks if they exist
  • Type hints with storage type not being adhered to by the Python frontend
  • Validation issue sdfg.validate goes on infinite recursion with loopy sdfg #1562

@tbennun tbennun added this to the 1.0 milestone Oct 28, 2024
@tbennun tbennun requested a review from phschaad October 29, 2024 05:01
@tbennun tbennun marked this pull request as ready for review October 29, 2024 05:02
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, LGTM. Looks like one GPU test fails due to wrongful arglist construction for a nested SDFG. I have encountered a similar issue numerous times on #1676 and fixed it there, but I suspect that the newly merged #1708 also fixed the issue? I have updated with main to verify.

@tbennun tbennun linked an issue Oct 29, 2024 that may be closed by this pull request
@tbennun tbennun changed the title Python frontend stability and dynamic thread-block fixes Python frontend stability and inline storage specification Oct 29, 2024
@tbennun tbennun enabled auto-merge October 29, 2024 17:44
@tbennun tbennun disabled auto-merge October 29, 2024 22:33
@tbennun tbennun merged commit 7cb93f2 into main Oct 29, 2024
10 checks passed
@tbennun tbennun deleted the pf-stability branch October 29, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdfg.validate goes on infinite recursion with loopy sdfg
2 participants