Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dace::math::pi and dace::math::nan on GPU #1759

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Fixed dace::math::pi and dace::math::nan on GPU #1759

merged 7 commits into from
Nov 15, 2024

Commits on Nov 14, 2024

  1. Now they work on GPU and also updated the functionality.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2ecb2d6 View commit details
    Browse the repository at this point in the history

  2. There is some special stuff that needs to be considered.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cdf01e4 View commit details
    Browse the repository at this point in the history

  3. This should work now.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8143feb View commit details
    Browse the repository at this point in the history

  4. Added tests for the NAN.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f8e2919 View commit details
    Browse the repository at this point in the history

  5. It seems that the mathematical functions are not constant.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f44e50b View commit details
    Browse the repository at this point in the history

  6. Forgot to mark a test as GPU only.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    85d3df3 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. It seems that FPGA does not like constexpr.

    @philip-paul-mueller
    philip-paul-mueller committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    90160d5 View commit details
    Browse the repository at this point in the history