Fix tutorial codegen #1925
Open
Fix tutorial codegen #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
requested changes
Feb 5, 2025
castigli
force-pushed
the
fix-tutorial-codegen
branch
from
246d066 to
3f18387
Compare
tbennun
requested changes
Feb 7, 2025
tests/tutorials/tutorials_test.py
Outdated
| ep = ExecutePreprocessor(timeout=600) | ||
| try: | ||
| assert ep.preprocess(nb) is not None, f"Got empty notebook for {notebook}" | ||
| except Exception: |
There was a problem hiding this comment.
Please raise that exception. Otherwise we cannot know what went wrong. It will just raise an assertion error.
There was a problem hiding this comment.
Sorry for the slow turnaround, I was on vacation.
I cleaned up the error handling.
castigli
force-pushed
the
fix-tutorial-codegen
branch
from
dc3ebac to
1b4d8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorial
codegen.ipynbhas a small bug, namely theControlFlowRegionis not in the correct namespace (as used in the tutorial).This PR fixes the issue by importing
ControlFlowRegionin thedacenamespace.Additionally I added a test for the notebook tutorials to make sure they are not broken.
At the moment I added only the "getting started" and "codegen" notebooks.
These tests require new dependencies
ipykernelandnbconvert.The above may or may not be the preferred solutions!