Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding C++ benchmarks #94 #145

Closed
wants to merge 19 commits into from
Closed

Conversation

AtulRajput01
Copy link

1.Added C++ benchmark for AWS Lambda
2.Implemented C++ benchmark using the benchmark library and AWS SDK for Lambda
3.Created a setup function to compile and run the C++ benchmark, and to create, invoke and delete a Lambda function
4.Stored the benchmark results in a map and printed the results for comparison between local and AWS Lambda runtimes
5.Tested the C++ benchmark on AWS Lambda to ensure accuracy and reproducibility

@AtulRajput01
Copy link
Author

Associated with #94

@mcopik
Copy link
Collaborator

mcopik commented Apr 26, 2023

@AtulRajput01

  • Did you notice there is an ongoing PR Add support for C++ benchmarks. #99 working towards the issue C++ benchmarks #94? The PR implements generic support to build different C++ serverless benchmarks, link dependencies, deploy, and execute.
  • Your solution seems to be a C++ file that manually compiles a C++ file and then tries to run it as a Lambda function. What's the purpose of that? What can we learn from such a benchmark?
  • The benchmark is also not added according to the directory structure of benchmarks.
  • The PR is missing the benchmark file itself - it just includes a file running a hardcoded g++ command to compile a missing benchmark function.

I'm voting to close this PR unless we get a better understanding of the purpose of this benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants