Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contentscript.css #117

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Update contentscript.css #117

merged 1 commit into from
Jul 29, 2023

Conversation

capfei
Copy link
Contributor

@capfei capfei commented Jul 28, 2023

selection-bubble background inherits based on light or dark mode.

For dark mode, changes
image

to look like
image

selection-bubble background inherits color based on light or dark mode
@alandtse
Copy link
Collaborator

Wow thanks. Does this address #105?

@capfei
Copy link
Contributor Author

capfei commented Jul 28, 2023

I only tested this on Chrome, Firefox on Windows to fix the selection box; not sure if it fixes dark mode issues on macOS. Sorry. Should I close this until I can test it?

@alandtse
Copy link
Collaborator

Oh no. It's a better situation then what it was. I was just wondering if I could close the issue once it's merged.

@alandtse alandtse merged commit b54f528 into spdx:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants