Dependency graph #152
Merged
Dependency graph #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogelio-o
commented
Jan 24, 2024
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.spdx</groupId> | ||
| <artifactId>spdx-maven-plugin-test</artifactId> |
There was a problem hiding this comment.
I had to replace the whitespaces for this test case because it threw the following error when building the MavenProject using ProjectBuilder:
org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
[ERROR] 'artifactId' with value 'spdx maven plugin test' does not match a valid id pattern. @ line 7, column 17
rogelio-o
commented
Jan 24, 2024
| import org.spdx.storage.ISerializableModelStore; | ||
| import org.spdx.storage.simple.InMemSpdxStore; | ||
|
|
||
| public class TestWithSessionSpdxMojo extends AbstractMojoTestCase |
There was a problem hiding this comment.
The mojos in TestSpdxMojo are created without a Maven session because they are loaded with lookupMojo. I had to use lookupConfiguredMojo to include a session to the mojo (and customize the session a bit). The session is used to generate the dependency graph.
goneall
requested changes
Jan 25, 2024
src/main/java/org/spdx/maven/utils/SpdxDependencyInformation.java
Outdated
Show resolved
Hide resolved
|
This fixes #87 |
Great! Thanks! Feedback applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes proposed in this pull request
Project name: Dependency graph #151
Description