Add support for SPDX Spec Version 3 #171
Conversation
NOTE: changes are not complete - this commit includes code that breaks the compilation. This is just an intermediate checking to save progress
Signed-off-by: Gary O'Neall <[email protected]>
|
As an update - the changes to the SPDX Java Library have been merged into the master branch. |
It seems that jsonschemafriend is no longer available in Maven Central so we need to add the jitpack repository - needed for the Integration Tests
Since we're not initializing or using the default model store, we need to always pass in a model store to the license expression parser methods. Note that not using the default avoids a potential memory issue for long running Maven scripts.
Cleaning up formatting - my IDE now has the Maven coding style added for this project, so it should be a bit cleaner going forward.
|
@hboutemy - This should now be ready for review. The libraries this new version depends on have been published so it should be a lot easier to test. I also just finished cleaning up the code and making sure all the integration tests and unit tests pass. Any review comments are very much appreciated. |
|
@hboutemy - Ping - let me know if you'll have time to review, otherwise I'll go ahead and merge and produce a release candidate version of the plugin. |
|
Hi @goneall any news on when this can be merged? I want to contribute to the aggregation issue for multi-module projects. I branched off your changes, and I was successful in making a new maven goal that would add the dependencies of all projects into one spdx.json file |
Since I haven't heard from @hboutemy - I'll go ahead and merge this PR. |
|
sorry, I had too many OSS engagements with too limited time, I failed at helping here |
Fixes #170
This is a rather large PR with some refactoring involved. For a description, see this comment.
This PR is currently in draft due to dependencies on some enhancements in the SPDX Java Library required for a successful compilation. These changes have been merged into the master branch of the java library but have not been released or published to Maven Central (reference spdx/Spdx-Java-Library#262)
To include this fix, you can pull down the latest code from the SPDX Java Library and build the dependency.
There is also a fix in the spdx-java-rdf-store which is required to pass the unit tests. This has been merged into the main - so you can pull down the latest from the project.
The code changes passes unit tests, but the integration tests are currently failing and a SonarCloud analysis has not been run - so there are likely some code cleanup issues to be found.