Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "v" from the 3.0.1 tag name in a link in change log #1153

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Nov 18, 2024

Tech Team Meeting 2024-11-05 agrees to drop "v" from the branch name.

Should this also be applied to the tag name as well?

If so, this PR is to update a link to 3.0.1 release notes,
from this: https://github.com/spdx/spdx-spec/releases/tag/v3.0.1
to this: https://github.com/spdx/spdx-spec/releases/tag/3.0.1

(Note that the page is not exist yet, until we have the tag.
The latest release notes that we have is at this URL:
https://github.com/spdx/spdx-spec/releases/tag/v3.0 )

Also update the date to the date of the latest merge.

Tech Team Meeting 2024-11-05 agrees to drop "v" from the branch name.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the doc improvement Area where the project documentation needs improvement label Nov 18, 2024
@bact bact added this to the 3.0.1 milestone Nov 18, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact
Copy link
Collaborator Author

bact commented Nov 18, 2024

I will merge this with one approval as it is a followup from the agreed point in the meeting

@bact bact merged commit 234629e into spdx:develop Nov 18, 2024
2 checks passed
@bact bact deleted the fix-link-to-tag branch November 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc improvement Area where the project documentation needs improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants