Proposal to allow any patch version for Lite specVersion Field #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to resolve https://github.com/spdx/spdx-3-model/blob/main/model/Lite/Lite.md Signed-off-by: Gary O'Neall <[email protected]>
|
Note: Validation checks failed, because of the known issue of missing CreationInfo for individuals, and they are irrelevant to the changes proposed by this PR. |
bact
approved these changes
Nov 19, 2024
bact
reviewed
Nov 19, 2024
| @@ -121,7 +121,7 @@ Additionally: | |||
| - Mandatory | |||
| 1. created | |||
| 1. createdBy (may be multiple), SHOULD be objects of type /Core/Agent | |||
| 1. specVersion, MUST be a fixed string, “3.0.1”. | |||
| 1. specVersion, MUST be a fixed string, “3.0.*” - where * is any supported dot version of the SPDX specification. | |||
There was a problem hiding this comment.
Suggested change
| 1. specVersion, MUST be a fixed string, “3.0.*” - where * is any supported dot version of the SPDX specification. | |
| 1. specVersion, MUST be a fixed string, “3.0.*” - where * is any supported dot version of the SPDX specification |
Stylistically, other list items in this page do not have fullstops. (The fullstop here is not introduced by this PR, it was there before) But I will leave this as optional so it will not blocking.
|
LGTM |
bact
reviewed
Nov 21, 2024
| @@ -121,7 +121,7 @@ Additionally: | |||
| - Mandatory | |||
| 1. created | |||
| 1. createdBy (may be multiple), SHOULD be objects of type /Core/Agent | |||
| 1. specVersion, MUST be a fixed string, “3.0.1”. | |||
| 1. specVersion, MUST be a fixed string, “3.0.*” - where * is any supported dot version of the SPDX specification. | |||
There was a problem hiding this comment.
I'm not sure which one is more formal between "patch release", "point release", and "dot release".
There was a problem hiding this comment.
Good point @bact - SEMVER uses the term "patch version". I'd propose changing "dot version" to "patch version". Let me know if you agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve https://github.com/spdx/spdx-3-model/blob/main/model/Lite/Lite.md