Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not fail when hf cache location contains unparseable paths #256

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

av
Copy link
Contributor

@av av commented Jan 18, 2025

Currently, speaches fails to load TTS models when HF cache contains custom files that do not follow the -- schema, this small fix skips over such files altogether, similarly to .locks

@fedirz
Copy link
Collaborator

fedirz commented Jan 18, 2025

Thx for the change. Could you just provide one example of such path

@av
Copy link
Contributor Author

av commented Jan 18, 2025

I use a lot of different inference engines and tools revolving around HF, a few examples from my local HF cache:

ls ~/.cache/huggingface/hub/
tmpd3p2ua2d
tmphejj1on8
tmphejj1on8
version.txt
datasets
metrics

Not all tools are playing with the cache nicely, relying on only native set of file present means that some other tool might break speaches unexpectedly (exactly what happened in my instance due to the files above)

@fedirz fedirz merged commit 5347c17 into speaches-ai:master Jan 18, 2025
3 checks passed
@fedirz
Copy link
Collaborator

fedirz commented Jan 18, 2025

Makes sense. Thx for creating the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants