Rework section title css classes #2773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap section title in <span class="sect-title">. Add <span class="secthdr" hidden>Chapter|Section|Appendix</span>
|
I'm working on updating the test so this passes. |
|
ok, cool - appreciate you taking the time to send these fixes. Will wait for update on the tests. Any issues, just give us a shout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap section title in <span class="sect-title">.
Add <span class="secthdr" hidden>Chapter|Section|Appendix</span>
The hidden span allows code that references a section to be formatted "Chapter 8" if so desired. This puts the code that picks the name Chapter|Section}|Appendix in one place.
Wrapping the title in sect-title simplifies potential css formatting of the title.