fix(core/dfn-panel): avoid using CSS variables #2888
Conversation
sidvishnoi
changed the title
| content: ""; | ||
| position: absolute; | ||
| border: 10px solid transparent; | ||
| border-top: 0; | ||
| border-bottom: 9px solid #a2a9b1; /* triangle outline */ | ||
| top: -9px; | ||
| left: calc(var(--caret-offset, 0px) + 0.75em); /* set via JS */ |
There was a problem hiding this comment.
Might be better to use attr() in the future rather than just reverting this. Google just posted an intent to implement for the feature. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/FGCgsKmylhw/BSUrk2roCQAJ
Since the validator is quite inactive, the browser implementation might be quicker.
There was a problem hiding this comment.
Looking at the code, the validator already supports attr() so we probably can just use it when the browser support lands.
There was a problem hiding this comment.
Even though nuHTML allows advanced attr(), CSS validator doesn't yet.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Hey, actually it does validate it!
.abc {
width: calc(attr(data-foo px) / 10);
}Try this code.
There was a problem hiding this comment.
Oh right! I missed the px suffix
Reverts hot-fix from https://github.com/w3c/respec/pull/2846 (See https://github.com/w3c/respec/issues/2845)
Precursor to https://github.com/w3c/respec/pull/2820
This changes the markup for dfnPanel, mainly converts the caret to a
<span>instead of::beforeas we cannot programmatically set position of::beforewithout CSS variables - which aren't supported by nuHTML validator.