Add formMeta menu in "View in Forms" and add unload protect to "Use Localized Field Labels" #5416
+49
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpatiiuk
approved these changes
Dec 3, 2024
specifyweb/frontend/js_src/lib/components/FormMeta/Definition.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Patiiuk <max@patii.uk>
CarolineDenis
approved these changes
Dec 6, 2024
Triggered by c2db63a on branch refs/heads/issue-2514-2
combs-a
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
- Create a new query
- Run the query and click "Browse in Forms"
- Check that the form meta button is there
- Make sure the settings within form meta work as expected
- Check Unload Protects:
- Click Form Meta -> Form Definition
- Click close and make sure no Unload Protect appears
- Click Form Meta -> Form Definition and toggle "Use Localized Field Labels"
- Click close and make sure an Unload Protect appears
- Save the query and try again
- Click close and make sure no Unload Protect appears
- Do the same for the Form Meta button in Data Entry
Looks good, didn't run into any issues--though I'm attaching a video to make sure I understood what you wanted from the unload protect testing. Let me know if I misunderstood it!
firefox_02-17_16-14.mp4
Good work! 👍
@combs-a Yep that looks good! The unload protect I added is triggered by the close button on the Form Definition dialog, so as long as it catches any unsaved changes before it forces a refresh then its working as intended. |
lexiclevenger
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
- Check that the form meta button is there
- Make sure the settings within form meta work as expected
- Click close and make sure no Unload Protect appears
- Click close and make sure an Unload Protect appears
- Click close and make sure no Unload Protect appears
- Do the same for the Form Meta button in Data Entry
Looks great, good job!
Triggered by a5ec979 on branch refs/heads/issue-2514-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2514
Expansion of #3594
Adds a formMeta button the "View in Forms" in query results (#3594) and adds an unload protect so toggling Localized Fields in Form Meta doesn't erased unsaved queries
Checklist
and self-explanatory (or properly documented)
Testing instructions