Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to delete tree root #6225

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Allow to delete tree root #6225

merged 1 commit into from
Feb 12, 2025

Conversation

CarolineDenis
Copy link
Contributor

Fixes #6224

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify@ed0b811ebcb6:/opt/specify7$ ve/bin/python manage.py migrate specify 0001
Operations to perform:
  Target specific migration: 0001_initial, from specify
Running migrations:
  Rendering model states... DONE
  Unapplying specify.0023_update_schema_config_text... OK
  Unapplying specify.0022_ensure_default_cots... OK
  Unapplying specify.0021_update_hidden_geo_tables... OK
  Unapplying specify.0020_add_tectonicunit_to_pc_in_schema_config... OK
  Unapplying specify.0019_remove_parentCog... OK
  Unapplying specify.0018_cot_catnum_schema... OK
  Unapplying specify.0017_schemaconfig_fixes... OK
  Unapplying specify.0016_collectionobjecttype_catalognumformatname... OK
  Unapplying specify.0015_add_version_to_ages... OK
  Unapplying specify.0014_spqueryfield_strict... OK
  Unapplying specify.0013_collectionobjectgroup_parentcog...[12/Feb/2025 17:48:19] [WARNING] [specifyweb.specify.migration_utils.update_schema_config:156] Field does not exist in latest state of the datamodel, skipping Schema Config entry for: CollectionObjectGroup -> parentCojo
 OK
  Unapplying specify.0012_add_cojo_to_schema_config... OK
  Unapplying specify.0011_cascading_tree_nodes... OK
  Unapplying specify.0010_updateDelete_parentcojo... OK
  Unapplying specify.0009_tectonic_ranks... OK
  Unapplying specify.0008_ageCitations_fix... OK
  Unapplying specify.0007_schema_config_update... OK
  Unapplying specify.0006_fix_tectonic_tree_fields... OK
  Unapplying specify.0005_collectionobjectgroup_parentcojo... OK
  Unapplying specify.0004_stratigraphy_age... OK
  Unapplying specify.0003_cotype_picklist... OK
  Unapplying businessrules.0005_cojo... OK
  Unapplying specify.0002_geo... OK

👍

Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now reviewing the code changes, let me test this in the app before merging

@grantfitzsimmons grantfitzsimmons self-requested a review February 12, 2025 17:49
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On issue-6224 when deleting a root rank:

image

On production when deleting a root rank:

image

@CarolineDenis CarolineDenis merged commit b8a05ca into production Feb 12, 2025
12 checks passed
@CarolineDenis CarolineDenis deleted the issue-6224 branch February 12, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reverting specify.0009_tectonic_ranks fails
4 participants