Fixed the issue of IP resources being exhausted when using multiple NICs #4359
+151
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
requested review from
weizhoublue,
cyclinder and
lou-lan
as code owners
ty-dc
force-pushed
the
fix/ip-allocate
branch
2 times, most recently
from
e9fbecf
to
94c0ea0
Compare
weizhoublue
reviewed
Dec 4, 2024
pkg/ipam/allocate.go
Outdated
| @@ -505,6 +505,11 @@ func (i *ipam) allocateIPFromCandidate(ctx context.Context, c *PoolCandidate, ni | |||
| continue | |||
| } | |||
|
|
|||
| if ip == nil || ip.Address == nil { | |||
There was a problem hiding this comment.
ip == nil || ip.Address == nil 为什么代表 “ its UID %s already exists in pool ”
并且 break
这块的代码可读性 不高
ty-dc
force-pushed
the
fix/ip-allocate
branch
from
94c0ea0
to
56fff92
Compare
weizhoublue
reviewed
Dec 4, 2024
pkg/ippoolmanager/ippool_manager.go
Outdated
| @@ -115,6 +115,11 @@ func (im *ipPoolManager) AllocateIP(ctx context.Context, poolName, nic string, p | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if allocatedIP == nil { | |||
| // The Pod has already obtained an IP address in the pool. | |||
| // We skip this allocation and return nil. | |||
There was a problem hiding this comment.
从这个 api 定义来看，为什么不是 把 分配的 ip return 出去，或者 在 相关的 return error 参数中 说明这种 case
而是用 ip为空 这种 非常有歧义的 方式来代表 ip 已经分配了
Signed-off-by: tao.yang <[email protected]>
ty-dc
force-pushed
the
fix/ip-allocate
branch
from
56fff92
to
b429b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #
Special notes for your reviewer:
Problem 1:
When ipam.spidernet.io/ippools does not specify an interface name, the network card information recorded in spiderEndpoint is incorrect.
Problem 2:
IP resources are exhausted，The 4102bd95-8f63-4f66-9b64-d7050e91b6c5 UID occupies IP resources indefinitely.
kubectl get sp default-v4-ippool -ojsonpath={.status.allocatedIPs} | jq { "172.18.40.10": { "pod": "default/ippool-test-app-58b7766c7c-mvwpf", "podUid": "4009cb83-bd17-4b08-92f0-2ea0cd3d64fc" }, "172.18.40.11": { "pod": "default/ippool-test-app-58b7766c7c-5jp5d", "podUid": "4e57d4ee-fd3f-44fa-8c80-1db2c6ae0e98" }, "172.18.40.12": { "pod": "default/ippool-test-app-58b7766c7c-gw8hd", "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5" }, "172.18.40.13": { "pod": "default/ippool-test-app-58b7766c7c-gw8hd", "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5" }, "172.18.40.19": { "pod": "default/ippool-test-app-58b7766c7c-gw8hd", "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5" }, "172.18.40.20": { "pod": "default/ippool-test-app-58b7766c7c-gw8hd", "podUid": "4102bd95-8f63-4f66-9b64-d7050e91b6c5" } }Problem 3:
Statefulset cannot be created without NICs