Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some dialyzer issues #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zdaniel86
Copy link

@zdaniel86 zdaniel86 commented Jul 9, 2016

Problem Description

Dependent project suffers from dialyzer issues such as:
src/erl_cache.erl:156: The call erl_cache:validate_opts(CacheOpts::any(),[]) will never return since it differs in the 2nd argument from the success typing arguments: (any(),'undefined') src/erl_cache.erl:157: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:202: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:229: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:252: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:300: The call erl_cache:validate_opts(Opts::any(),[]) will never return since it differs in the 2nd argument from the success typing arguments: (any(),'undefined') src/erl_cache.erl:301: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:397: The call erl_cache:default(Key::'key_generation',Defaults::[{'error_validity' | 'evict' | 'evict_interval' | 'is_error_callback' | 'key_generation' | 'max_cache_size' | 'mem_check_interval' | 'refresh_callback' | 'validity' | 'wait_for_refresh' | 'wait_until_done',atom() | fun() | non_neg_integer() | {_,_,_}}]) breaks the contract (config_key(),cache_opts()) -> term()

Solution Description

All these issues caused by single type config_key()
This change doesn't touch real functionality. So it can be merged without careful testing. It just makes dialyzer little bit more happy.

@spil-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://jenkins-spapi.avproxy.prd.ams1.spil/job/erl-cache-ghprb/4/
Test PASSed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants