Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Dependent project suffers from dialyzer issues such as:
src/erl_cache.erl:156: The call erl_cache:validate_opts(CacheOpts::any(),[]) will never return since it differs in the 2nd argument from the success typing arguments: (any(),'undefined') src/erl_cache.erl:157: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:202: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:229: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:252: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:300: The call erl_cache:validate_opts(Opts::any(),[]) will never return since it differs in the 2nd argument from the success typing arguments: (any(),'undefined') src/erl_cache.erl:301: The pattern {'ok', ValidatedOpts} can never match the type {'error',{'invalid','cache_name'}} src/erl_cache.erl:397: The call erl_cache:default(Key::'key_generation',Defaults::[{'error_validity' | 'evict' | 'evict_interval' | 'is_error_callback' | 'key_generation' | 'max_cache_size' | 'mem_check_interval' | 'refresh_callback' | 'validity' | 'wait_for_refresh' | 'wait_until_done',atom() | fun() | non_neg_integer() | {_,_,_}}]) breaks the contract (config_key(),cache_opts()) -> term()
Solution Description
All these issues caused by single type config_key()
This change doesn't touch real functionality. So it can be merged without careful testing. It just makes dialyzer little bit more happy.