Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kubernetes): convert undo rollout manifest stage to react #10159

Conversation

cristhian-castaneda
Copy link
Member

Overview

This PR addresses the refactoring of the Undo Rollout (Manifest) stage, part of the ongoing effort to transition Kubernetes stages to React. For additional context, please refer to spinnaker/spinnaker#4254

Changes Made

  • Refactored Components:
    • The files undoRolloutManifestConfig.html and undoRolloutManifestConfig.controller.ts have been converted into the new components UndoRolloutManifestConfig.tsx and UndoRolloutManifestStageForm.tsx.

Stage Views

Stage Config

image

Execution Details Sections

Undo Rollout Manifest

image

Execution Details Tasks

image

Copy link
Collaborator

@siddhu-opsmx siddhu-opsmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddhu-opsmx siddhu-opsmx added ready to merge Reviewed and ready for merge and removed ready to merge Reviewed and ready for merge labels Jan 26, 2025
@mergify mergify bot added the auto merged Merged automatically by a bot label Jan 28, 2025
@mergify mergify bot merged commit 824e0e5 into spinnaker:master Jan 28, 2025
4 checks passed
@cristhian-castaneda cristhian-castaneda deleted the refactor/reactify-undo-rollout-manifest-stage branch January 28, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.37
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants