fix(notifications): fix MicrosoftTeamsConfig which has unused retrofit1 parameters #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirangodishala
commented
Mar 4, 2025
kirangodishala
commented
- fixed MicrosoftTeamsConfig
- added a test to verify that MicrosoftTeamsService gets created now
dbyron-sf
reviewed
Mar 4, 2025
...notifications/src/test/java/com/netflix/spinnaker/echo/config/MicrosoftTeamsServiceTest.java
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
fix-microsoftteams
branch
from
aa6fa7d to
bde56a2
Compare
dbyron-sf
approved these changes
Mar 4, 2025
|
@Mergifyio backport release-1.37.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Mar 4, 2025
…t1 parameters (#1485) (#1486) (cherry picked from commit 41b1832) Co-authored-by: Kiran Godishala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.