Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/video #9

Merged
merged 2 commits into from
Jan 6, 2016
Merged

Feature/video #9

merged 2 commits into from
Jan 6, 2016

Conversation

heavybeard
Copy link
Collaborator

Add new feature: zoom on video too

heavybeard added a commit that referenced this pull request Jan 6, 2016
@heavybeard heavybeard merged commit 575b387 into master Jan 6, 2016
@heavybeard heavybeard deleted the feature/video branch January 6, 2016 13:52
@spinningarrow
Copy link
Owner

Thanks for being so active on this project!
Just wondering - is this something that came from upstream (fat/zoom.js) or our own thing?

@spinningarrow
Copy link
Owner

Btw, the video files have made this repository super heavy. What do you say to using some already-hosted video files instead?

@heavybeard
Copy link
Collaborator Author

this is a new feature developed by me with a pull request here fat#66

I tested it on multiple browsers and mobile too and it works well, so I decide to merge on master project.

I can upload tomorrow other videos (<5mb) or I can try to link to an extarnal resource

spinningarrow pushed a commit that referenced this pull request Jan 19, 2016
@spinningarrow
Copy link
Owner

I've uploaded smaller videos now as a part of #12.

@heavybeard
Copy link
Collaborator Author

Many thanks

@ElegantSudo
Copy link

@spinningarrow could you take a look at this? I've been trying to create a solution, but it's been a pretty hard challenge to solve. fat#77

@spinningarrow
Copy link
Owner

@ElegantSudo could you give me a codepen or something that demonstrates the problem? I mostly need it for testing.

@ElegantSudo
Copy link

ElegantSudo commented Jun 29, 2016

@spinningarrow of course! http://codepen.io/yipyop/pen/RRpOKQ

I've outlined the problem and given an example.

@spinningarrow
Copy link
Owner

Looks good! Thanks a lot; I'll take a crack at it.

@spinningarrow
Copy link
Owner

@ElegantSudo take a look at #18 when you can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants