implement second bitmap, ~2x speedup for train #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ this is a sad flamegraph.
bzero
is not a fun place to be spending 60% of your time.How did we get from one to two?
counts1
andcounts1
vectorsoptimize
. Becausecounts1
andcounts2
are not initialized, we check the bitmap before all accessesThis also gives us another 2x speedup on the train benchmark, which is nice