-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get compress performance to match paper algorithm 4 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Aug 14, 2024
a10y
commented
Aug 15, 2024
lwwmanning
reviewed
Aug 15, 2024
@@ -0,0 +1,63 @@ | |||
The unanimous Declaration of the thirteen united States of America, When in the Course of human events, it becomes necessary for one people to dissolve the political bands which have connected them with another, and to assume among the powers of the earth, the separate and equal station to which the Laws of Nature and of Nature's God entitle them, a decent respect to the opinions of mankind requires that they should declare the causes which impel them to the separation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇺🇸 ❤️
a10y
changed the title
[WIP] get compress performance to match paper algorithm 4
Get compress performance to match paper algorithm 4
Aug 15, 2024
lwwmanning
approved these changes
Aug 15, 2024
Merged
a10y
pushed a commit
that referenced
this pull request
Aug 15, 2024
## 🤖 New release * `fsst-rs`: 0.0.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.0.1](https://github.com/spiraldb/fsst/releases/tag/v0.0.1) - 2024-08-15 ### Fixed - fix doc link ### Other - turn on release-plz - add fuzzer, fix bug ([#7](#7)) - logo ([#6](#6)) - bugfix, comment fix, force compile fails for big-endian ([#5](#5)) - Configure Renovate ([#1](#1)) - Get compress performance to match paper algorithm 4 ([#3](#3)) - docs - cleanup - words - README - disable release action for now - deny(missing_docs), 512 -> 511 - add toolchain - add actions files - implementation v0 - initial impl - Initial commit </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us close to 2-3 cycles per byte or so that they reference in the paper for predicated scalar compression.
^ the benchmark is compression on string with length 50, so compression is roughly 1-2ns per byte (roughly 3-5 cycles on my M2)