bugfix, comment fix, force compile fails for big-endian #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Aug 15, 2024
| @@ -48,40 +45,5 @@ fn bench_fsst(c: &mut Criterion) { | |||
| }); | |||
| } | |||
|
|
|||
| fn bench_lz4(c: &mut Criterion) { | |||
There was a problem hiding this comment.
these were kinda useless
AdamGS
reviewed
Aug 15, 2024
| @@ -9,6 +11,8 @@ that they should declare the causes which impel them to the separation."#; | |||
|
|
|||
| static DECLARATION: &str = include_str!("./fixtures/declaration.txt"); | |||
|
|
|||
| static ART_OF_WAR: &str = include_str!("./fixtures/art_of_war.txt"); | |||
a10y
commented
Aug 15, 2024
| let symbol2 = &self.symbols[code2 as usize]; | ||
| // If either symbol is zero-length, or if merging would yield a symbol of | ||
| // length greater than 8, skip. | ||
| if symbol1.len() + symbol2.len() >= 8 || symbol1.is_empty() || symbol2.is_empty() { |
There was a problem hiding this comment.
symbols can never be empty, the last PR changed that
a10y
commented
Aug 15, 2024
| @@ -103,19 +103,19 @@ impl SymbolTable { | |||
| fn optimize(&self, counters: Counter) -> Self { | |||
| let mut res = SymbolTable::default(); | |||
| let mut pqueue = BinaryHeap::new(); | |||
| for code1 in 0..511 { | |||
| for code1 in 0u16..(256u16 + self.n_symbols as u16) { | |||
There was a problem hiding this comment.
Changing the loop bound here and below gave us a nice little speedup
Merged
a10y
pushed a commit
that referenced
this pull request
Aug 15, 2024
## 🤖 New release * `fsst-rs`: 0.0.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.0.1](https://github.com/spiraldb/fsst/releases/tag/v0.0.1) - 2024-08-15 ### Fixed - fix doc link ### Other - turn on release-plz - add fuzzer, fix bug ([#7](#7)) - logo ([#6](#6)) - bugfix, comment fix, force compile fails for big-endian ([#5](#5)) - Configure Renovate ([#1](#1)) - Get compress performance to match paper algorithm 4 ([#3](#3)) - docs - cleanup - words - README - disable release action for now - deny(missing_docs), 512 -> 511 - add toolchain - add actions files - implementation v0 - initial impl - Initial commit </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add tests with chinese characters