Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement StructValue proto serde without google.protobuf.Value (#343)
Move away from google.protobuf.Value. It makes things unnecessary complicated - number is always f64, look at the previous logic for handling struct.... It seems like the Value models JSON value which is not what we need. I considered using google.protobuf wrappers, e.g. BytesValue, Int32Value, instead of primitives but those are also for usage with JSON or with proto2 (before optional was introduced to enable optional primitive fields), so decided to use proto primitives. Adds to proto and try from proto.
- Loading branch information