Skip to content

Commit

Permalink
Update maturin to 1.7.2 to reduce pyvortex dependencies (#944)
Browse files Browse the repository at this point in the history
fixes #771 , remake of #772
  • Loading branch information
robert3005 authored Sep 27, 2024
1 parent d22aa29 commit 2c54ff9
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 26 deletions.
9 changes: 0 additions & 9 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dev-dependencies = [
"pytest-benchmark>=4.0.0",
"ruff>=0.1.11",
"pip>=23.3.2",
"maturin>=1.4.0",
"maturin>=1.7.2",
]

[tool.rye.workspace]
Expand Down
17 changes: 3 additions & 14 deletions pyvortex/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,15 @@ tokio = { workspace = true, features = ["fs"] }

vortex-alp = { workspace = true }
vortex-array = { workspace = true }
vortex-buffer = { workspace = true }
vortex-bytebool = { workspace = true }
vortex-datafusion = { workspace = true }
vortex-datetime-dtype = { workspace = true }
vortex-datetime-parts = { workspace = true }
vortex-dict = { workspace = true }
vortex-dtype = { workspace = true, default-features = false }
vortex-dtype = { workspace = true }
vortex-error = { workspace = true }
vortex-expr = { workspace = true }
vortex-fastlanes = { workspace = true }
vortex-flatbuffers = { workspace = true }
vortex-fsst = { workspace = true }
vortex-proto = { workspace = true }
vortex-roaring = { workspace = true }
vortex-runend = { workspace = true }
vortex-runend-bool = { workspace = true }
vortex-sampling-compressor = { workspace = true }
vortex-scalar = { workspace = true, default-features = false }
vortex-serde = { workspace = true, default-features = false, features = ["tokio"] }
vortex-scalar = { workspace = true }
vortex-serde = { workspace = true, features = ["tokio"] }
vortex-zigzag = { workspace = true }

# We may need this workaround?
# https://pyo3.rs/v0.20.2/faq.html#i-cant-run-cargo-test-or-i-cant-build-in-a-cargo-workspace-im-having-linker-issues-like-symbol-not-found-or-undefined-reference-to-_pyexc_systemerror
2 changes: 1 addition & 1 deletion pyvortex/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Issues = "https://github.com/spiraldb/vortex/issues"
Benchmarks = "https://spiraldb.github.io/vortex/dev/bench/"

[build-system]
requires = ["maturin>=1.2,<2.0"]
requires = ["maturin>=1.7.2,<2.0"]
build-backend = "maturin"

[tool.rye]
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.lock
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ kiwisolver==1.4.7
markupsafe==2.1.5
matplotlib==3.9.2
matplotlib-inline==0.1.7
maturin==1.5.1
maturin==1.7.4
numpy==1.26.4
packaging==24.0
pandas==2.2.2
Expand Down

0 comments on commit 2c54ff9

Please sign in to comment.