Skip to content

Commit

Permalink
make CI bench tests faster (take 2) (#897)
Browse files Browse the repository at this point in the history
for now, we just exclude the compress_benchmark

on my M2 macbook air, `time` for the command with exclusion was `cargo
bench --bench '*[!noci]' -- --test 42.99s user 13.41s system 92% cpu
1:00.74 total`
  • Loading branch information
lwwmanning authored Sep 20, 2024
1 parent a7841c9 commit 4620f2a
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/bench-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ jobs:
strategy:
matrix:
benchmark:
- id: tpch_benchmark
- id: tpch
# this was the original name which we must preserve until we change the name of all the
# records in the gh-pages-bench branch "Vortex benchmarks"
name: Vortex benchmarks
- id: compress_benchmark
- id: compress_noci
name: Vortex Compression
- id: bytes_at
name: Vortex bytes_at
- id: datafusion_benchmark
- id: datafusion
name: Vortex DataFusion
- id: random_access
name: Vortex random_access
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ jobs:
strategy:
matrix:
benchmark:
- id: tpch_benchmark
- id: tpch
# this was the original name which we must preserve until we change the name of all the
# records in the gh-pages-bench branch "Vortex benchmarks"
name: Vortex benchmarks
- id: compress_benchmark
- id: compress_noci
name: Vortex Compression
- id: bytes_at
name: Vortex bytes_at
- id: datafusion_benchmark
- id: datafusion
name: Vortex DataFusion
- id: random_access
name: Vortex random_access
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ jobs:
with:
version: v1.0.0
- name: Rust Bench as test
run: cargo bench --benches -- --test
run: cargo bench --bench '*[!noci]' -- --test
8 changes: 4 additions & 4 deletions bench-vortex/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -81,22 +81,22 @@ test = false
bench = false

[[bench]]
name = "compress_benchmark"
harness = false
name = "compress_noci"
test = false
harness = false

[[bench]]
name = "random_access"
test = false
harness = false

[[bench]]
name = "datafusion_benchmark"
name = "datafusion"
test = false
harness = false

[[bench]]
name = "tpch_benchmark"
name = "tpch"
test = false
harness = false

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 4620f2a

Please sign in to comment.