exclude ALP for now

spiraldb · Oct 2, 2024 · 51417a5 · 51417a5
1 parent 2a84550
commit 51417a5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/bench-vortex/src/lib.rs b/bench-vortex/src/lib.rs
@@ -19,7 +19,7 @@ use vortex::compress::CompressionStrategy;
 use vortex::{Array, Context, IntoArray};
 use vortex_dtype::DType;
 use vortex_fastlanes::DeltaEncoding;
-use vortex_sampling_compressor::compressors::alp::ALPCompressor;
+// use vortex_sampling_compressor::compressors::alp::ALPCompressor;
 use vortex_sampling_compressor::compressors::bitpacked::BitPackedCompressor;
 use vortex_sampling_compressor::compressors::date_time_parts::DateTimePartsCompressor;
 use vortex_sampling_compressor::compressors::dict::DictCompressor;
@@ -53,8 +53,8 @@ lazy_static! {
 
 lazy_static! {
     pub static ref COMPRESSORS: HashSet<CompressorRef<'static>> = [
-        &ALPCompressor as CompressorRef<'static>,
-        &DictCompressor,
+        // &ALPCompressor as CompressorRef<'static>,
+        &DictCompressor as CompressorRef<'static>,
         &BitPackedCompressor,
         &FoRCompressor,
         &FSSTCompressor,

diff --git a/vortex-sampling-compressor/src/compressors/alp.rs b/vortex-sampling-compressor/src/compressors/alp.rs
@@ -51,9 +51,11 @@ impl EncodingCompressor for ALPCompressor {
 
         let compressed_patches = patches
             .map(|p| {
-                ctx.auxiliary("patches")
-                    .excluding(self)
-                    .compress(&p, like.as_ref().and_then(|l| l.child(1)))
+                ctx.auxiliary("patches").excluding(self).compress(
+                    &p,
+                    like.as_ref()
+                        .and_then(|l| if l.nchildren() >= 2 { l.child(1) } else { None }),
+                )
             })
             .transpose()?;