-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #695. `rye build` failed when it tried to build the sdist to produce a wheel. This failed because some _transitive_ workspace dependencies (e.g. vortex-proto) were not present in the sdist. The root cause appears to be a bug in maturin. I saw [a similar issue on their repo](PyO3/maturin#2117 (comment)). I shared a branch with them that reproduces the behavior. Until this issue is resolved, we can work around it by explicitly depending on every workspace crate. Two unrelated issues are also fixed here: 1. We must propagate the Rust toolchain to the sdist build environment. 2. `vortex-bytebool` was misnamed in the root Cargo.toml. I'm not sure why this isn't a problem for other crates?
- Loading branch information
Showing
5 changed files
with
29 additions
and
8 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ authors = [ | |
{ name = "Nicholas Gates", email = "[email protected]" } | ||
] | ||
dependencies = [ | ||
"pydata-sphinx-theme>=0.15.4", | ||
"pyarrow>=15.0.0", | ||
] | ||
requires-python = ">= 3.11" | ||
classifiers = ["Private :: Do Not Upload"] | ||
|
@@ -18,14 +18,15 @@ build-backend = "maturin" | |
[tool.rye] | ||
managed = true | ||
dev-dependencies = [ | ||
"pyarrow>=15.0.0", | ||
"pip", | ||
"sphinx>=8.0.2", | ||
"ipython>=8.26.0", | ||
"pandas>=2.2.2", | ||
"pip", | ||
"pydata-sphinx-theme>=0.15.4", | ||
"sphinx>=8.0.2", | ||
] | ||
|
||
[tool.maturin] | ||
python-source = "python" | ||
module-name = "vortex._lib" | ||
features = ["pyo3/extension-module"] | ||
include = [{ path = "rust-toolchain.toml", format = "sdist" }] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../rust-toolchain.toml |