feat: improved objective function in sampling compressor #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8765d45.
|
Can you separate the last two as separate changes? |
robert3005
reviewed
Oct 9, 2024
robert3005
reviewed
Oct 9, 2024
robert3005
reviewed
Oct 9, 2024
robert3005
reviewed
Oct 9, 2024
a10y
reviewed
Oct 9, 2024
|
note: as of commit 45560d4, we get 10-25% improved compression throughput with roughly equal file sizes
where baseline develop is against commit 4aa30c0 this is still using the MinSize strategy, albeit now estimating metadata size rather than just data buffer size. |
lwwmanning
changed the title
robert3005
requested changes
Oct 10, 2024
This reverts commit e110b26.
|
We should still get rid of the Compressor::only function. Once we have a use case happy to reconsider |
robert3005
approved these changes
Oct 10, 2024
a10y
added a commit
that referenced
this pull request
Dec 19, 2024
Fixes issue seen in #1723 In #1000, changes were made to remove ALP-RD as a top-level compressor and instead to only use it for patches. However, it seems that it was not getting selected anymore, whether that was due to the patching cost overhead or something else. This was noticed by a user, and confirmed by me in a Python shell. <img width="946" alt="image" src="https://github.com/user-attachments/assets/c42caed5-12e3-448b-aea6-3f33a7c97bfc" /> After this change, ALP-RD indeed does get selected again. <img width="907" alt="image" src="https://github.com/user-attachments/assets/bbb996fc-5223-43ed-9b4c-4b0262a417dc" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things:
But the headliner is that we now add a (configurable) overhead of 64 bytes per descendant array, which penalizes additional levels of cascading compression that don't do much.
The
compress_nocibenchmark shows ~10-30% higher compression throughput, and 10-70% higher decompression throughput, with file sizes +/- 3% compared todevelop.