feat: concise benchmark names #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to rename the data.js file to conform to these new names (and to kill parquet uncompressed) after this merges. I can also slim down #1009 (e.g. don't need to hide parquet uncompressed if we stop generating it). |
robert3005
approved these changes
Oct 10, 2024
a10y
approved these changes
Oct 10, 2024
Currently the Taxi and l_comment datasets are their own Criterion "group" which causes them to be plotted separately. With this PR, there is one plot for "compress time" which is measured in seconds and has every dataset. I also eliminated the comparison to uncompressed Parquet because (except for a tiny 1024 byte dataset) we always beat uncompressed Parquet. Parquet with ZSTD is a sufficient comparison. Finally, I removed some characters from several benchmark names in hopes that the Markdown tables on GitHub are more legible.
danking
force-pushed
the
dk/slimmer-benchmark-names
branch
from
284cf99 to
88d910d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Taxi and l_comment datasets are their own Criterion "group" which causes them to be plotted separately. With this PR, there is one plot for "compress time" which is measured in seconds and has every dataset.
I also eliminated the comparison to uncompressed Parquet because (except for a tiny 1024 byte dataset) we always beat uncompressed Parquet. Parquet with ZSTD is a sufficient comparison.
Finally, I removed some characters from several benchmark names in hopes that the Markdown tables on GitHub are more legible.