Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts have buffers and there's self describing schema layout #1098

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

robert3005
Copy link
Member

@robert3005 robert3005 commented Oct 19, 2024

No description provided.

@robert3005
Copy link
Member Author

@gatesn I think your suggestion to have buffers makes sense. When I was adding layout for metadata I needed something that's not a layout itself but it's inline with data

@robert3005 robert3005 enabled auto-merge (squash) October 21, 2024 15:21
vortex-serde/src/layouts/write/layouts.rs Show resolved Hide resolved
vortex-serde/src/layouts/write/layouts.rs Show resolved Hide resolved
vortex-serde/src/layouts/write/writer.rs Show resolved Hide resolved
vortex-serde/src/layouts/read/layouts/flat.rs Show resolved Hide resolved
@lwwmanning lwwmanning dismissed their stale review October 21, 2024 21:43

misunderstood

@robert3005
Copy link
Member Author

Added validation to the ranges on write

@robert3005 robert3005 merged commit 96f819f into develop Oct 22, 2024
5 checks passed
@robert3005 robert3005 deleted the rk/flatschemalayout branch October 22, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants