feat: FSSTArray::into_canonical directly build VarBinView #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
commented
Oct 29, 2024
a10y
force-pushed
the
aduffy/fsst-to-view
branch
from
0e3d425 to
e84624b
Compare
robert3005
approved these changes
Oct 29, 2024
|
You’re so fast 💨 |
lwwmanning
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had been building a VarBin and then using arrow_cast to cast into a VarBinView.
The implementation of arrow_cast for Utf8 -> Utf8View should be relatively efficient because it tries to reuse the buffer. However, it's likely more efficient to do the construction in a single-pass