-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store benchmarks in s3 #1650
Merged
Merged
+872
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may be easier to write this in |
danking
added
benchmark
Run benchmarks on this branch
and removed
benchmark
Run benchmarks on this branch
labels
Dec 11, 2024
danking
force-pushed
the
dk/store-bench-in-s3
branch
from
December 11, 2024 21:07
e53d4f2
to
a2ef0ca
Compare
lwwmanning
approved these changes
Dec 12, 2024
Benchmarks: compress
|
This reverts commit e5bd9ea.
danking
force-pushed
the
dk/store-bench-in-s3
branch
from
December 13, 2024 17:19
6223ac9
to
0ff191c
Compare
danking
added
do not merge
Pull requests that are not intended to merge
and removed
do not merge
Pull requests that are not intended to merge
labels
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmarks-website
(necessary for it to be deployed together with the docs)scripts
folder (I am sorry for my sins)cat-s3.sh
: compare-and-swap new benchmarks into S3.coerce-criterion-json.sh
: converts criterion's (weirdo) json format to the new one above.,commit-json.sh
: generates a commit JSON (which is stored in s3://.../commits.json a database commit metadata).compare-benchmark-jsons.py
: loads two JSONL files (containing data for just one commit each) and creates a Markdown table of comparisons.