Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty line between summary tag and start of markdown table #1682

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: empty line between summary tag and start of markdown table #1682

merged 1 commit into from
Dec 13, 2024
+3 −0

Conversation

danking
Copy link
Member

@danking danking commented Dec 13, 2024

No description provided.

@danking danking marked this pull request as ready for review December 13, 2024 19:33
@lwwmanning lwwmanning enabled auto-merge (squash) December 13, 2024 19:33
@lwwmanning lwwmanning disabled auto-merge December 13, 2024 19:34
@lwwmanning lwwmanning added the benchmark Run benchmarks on this branch label Dec 13, 2024
@github-actions github-actions bot removed the benchmark Run benchmarks on this branch label Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Benchmarks: random_access

Table of Results
name PR 07cf13f base fc58b6d ratio (PR/base) unit
random-access/vortex-tokio-local-disk 2.89691e+06 2.92337e+06 0.990949 ns
random-access/vortex-local-fs 2.98409e+06 3.00368e+06 0.993478 ns
random-access/parquet-tokio-local-disk 2.3163e+08 2.24738e+08 1.03066 ns

@github-actions GitHub Actions
Copy link
Contributor

Benchmarks: datafusion

Table of Results
name PR 07cf13f base fc58b6d ratio (PR/base) unit
arrow/planning 795982 804108 0.989894 ns
arrow/exec 1.74489e+06 1.75695e+06 0.993135 ns
vortex-pushdown-compressed/planning 499079 500651 0.99686 ns
vortex-pushdown-compressed/exec 2.60822e+06 2.64733e+06 0.985227 ns
vortex-pushdown-uncompressed/planning 495045 507907 0.974676 ns
vortex-pushdown-uncompressed/exec 1.5192e+06 1.48394e+06 1.02376 ns
vortex-nopushdown-compressed/planning 815777 825931 0.987707 ns
vortex-nopushdown-compressed/exec 2.85272e+06 2.95022e+06 0.966951 ns
vortex-nopushdown-uncompressed/planning 812674 820085 0.990964 ns
vortex-nopushdown-uncompressed/exec 4.82183e+06 4.8384e+06 0.996575 ns

@lwwmanning lwwmanning merged commit 18268bc into develop Dec 13, 2024
18 of 21 checks passed
@lwwmanning lwwmanning deleted the dk/fix-pr-benchmarks-markdown branch December 13, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwwmanning lwwmanning lwwmanning approved these changes

Assignees

@lwwmanning lwwmanning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danking @lwwmanning