Array2: swap trait for struct with lifetime #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
added a commit
that referenced
this pull request
Apr 7, 2024
Starting to add a few more implementations to the new structure. Takeaways: - [x] Validity probably doesn't need to be an array encoding. And now we have `Array<'a>` we don't need Validity + ValidityView. Instead, we can provide helper functions based on metadata + array data. The next two are addressed in #215 - [x] There's lots of duplication between the `impl &dyn FooArray for Array{Data, View}`. Mostly it's just accessing children or buffers. - [x] With the Array enum, we may not need each array to be a trait and could be a struct that holds Arrays?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have an Array<'a> enum, we can swap out the array trait and things get a little simpler.